0xrsydn 3d67b136ba fix(cpu): store PC plus six for Thumb empty register lists

Correct the shared Thumb block-store PC offset from four to six bytes. Retain ARM PC+12, 64-byte empty-list writeback, normal load behavior, alignment, flags, and nominal timing. Correct prior internal expectations and add original regressions for bases, banks, alignment, ROM windows, writeback, clocks, and atomic errors.

The pinned public Thumb ROM now passes its unchanged ARM-state r7 checkpoint after 807 steps and 4170 nominal cycles. The pinned ARM ROM still passes. Neither external ROM nor result assertion is modified.

Validated on Darwin arm64: 848 workspace tests in debug and release; 779 core/demo tests separately; 21 Python adapter tests; both public suites in both profiles; native ROM-window tests; all ten demo window smoke tests; fmt, clippy, rustdoc, and local documentation links.

2026-10-05 20:47:39 +07:00

12 KiB

Raw Blame History

References

External sources consulted while implementing the emulator. Add new sources here, or in a "References" section of the matching docs/hardware/ file when a link explains one specific behavior.

Hardware references used for the core:

GBATEK ARM instruction cycle times.
GBATEK GBA system control and WAITCNT, including HALTCNT power-mode selection.
GBATEK BIOS reset functions, for SoftReset state and restart selection, plus RegisterRamReset flags, RAM bounds, and forced blank.
GBATEK BIOS halt functions, for wait contracts, STOP clock gating, allowed wake sources, and the clock-off IF note.
GBATEK BIOS function calling conventions.
GBATEK BIOS memory-copy services.
GBATEK BIOS rotation/scaling services, for record layouts, angle units, and output strides.
VisualBoyAdvance-M BIOS services, reviewed for integer affine rounding, signed matrix intermediates, and SoftReset status handling. Our sine table is generated mathematically.
GBATEK BIOS arithmetic services.
GBATEK BIOS decompression services, including BitUnPack descriptor fields, differential-filter headers, Huffman tree layout, and width constraints.
mGBA BIOS service implementation, reviewed for RegisterRamReset register defaults, angle-polynomial coefficients and quadrant conventions, BitUnPack ordering/offsets, and Huffman tree layout and packing.
HALTCNT hardware-access tests, for BIOS-only writes and halfword access.
GBATEK display status and IRQs.
GBATEK display dimensions and timings.
mGBA display implementation, used to cross-check hidden-line HBlank IRQs and comparison-write edges.
GBATEK affine background registers.
NanoBoyAdvance background implementation, reviewed for internal origins, line-end increments, and affine mosaic behavior.
GBATEK text and affine map layouts.
GBATEK background control.
GBATEK tile/map memory layout.
mGBA text-background renderer, reviewed for out-of-range fetch behavior.
GBATEK sprite overview and rendering limits.
mGBA sprite preprocessing and row preparation, reviewed for inspection costs and aggregate work limits.
GBATEK sprite attributes.
GBATEK sprite rotation/scaling parameters.
GBATEK sprite tile mapping.
Tonc regular sprites.
mGBA sprite renderer, reviewed for tile alignment and wrapping.
GBATEK bitmap backgrounds.
GBATEK display control.
GBATEK window registers and priority.
GBATEK color special effects.
GBATEK mosaic register.
NanoBoyAdvance text sampling, reviewed for vertical counter subtraction.
NanoBoyAdvance mosaic registers, reviewed for phase-preserving size writes and documented timing uncertainties.
Horizontal sprite mosaic hardware findings, for latch transitions and transparent metadata.
NanoBoyAdvance sprite pipeline, reviewed for one-row-ahead preparation, mosaic phase, priority updates, and OBJ-window exclusions.
NanoBoyAdvance display scheduling, reviewed for cycle40 sprite initialization, line227 preparation, and vertical window comparisons on hidden lines.
NanoBoyAdvance composition, reviewed for palette lookup and horizontal mosaic after sprite preparation.
mGBA window renderer, reviewed for inverted bounds and vertical edge flags.
NanoBoyAdvance window implementation, reviewed for persistent vertical flags, four-cycle horizontal comparisons, offscreen columns, and end-edge precedence.
GBATEK keypad input, for KEYINPUT/KEYCNT fields and selected-button OR/AND matching.
mGBA keypad sampling and control writes, reviewed for repeated OR requests, AND snapshot suppression, and newly selected held keys.
NanoBoyAdvance keypad implementation, compared for control access widths; its AND/retrigger behavior differs from the chosen polling model.
mGBA keypad timing issue, for frontend frame-based input timing limits.
Tonc hardware interrupts, for keypad source enable and IF/IE bit 12.
GBATEK memory mirrors, video byte writes, and unused-memory reads, for unused address ranges, ARM PC+8 open bus, byte lanes, and the distinct Thumb region/history rules.
nocash GBA open-bus discussion, for the distinction between ARM prefetch and region-dependent Thumb values.
mGBA memory implementation, reviewed for GBALoadBad, ARM prefetch sourcing, byte/halfword lane selection, and separate DMA/history behavior.
GBATEK GBA memory map and bus widths.
GBATEK GBA DMA transfers.
mGBA DMA implementation, used to cross-check masks, repeat behavior, and Game Pak source increments.
GBATEK GBA timers.
GBATEK GBA interrupt control.
GBATEK processor registers and modes.
GBATEK status transfers.
GBATEK CPU exceptions.
GBATEK ARM data processing, including R15/status notes. Its legacy {P} description alone does not establish ARM7 behavior.
mGBA ARM instruction implementation, reviewed for Rd=15 test/compare SPSR restoration, User/System fallback, and no result write/refill. Also reviewed its word/byte/halfword/signed load ordering: writeback precedes the destination result.
jsmolka/gba-tests, pinned for independent ARM testing. Reviewed its MIT license, startup, result macros, compare/status tests, and load/writeback alias tests.
Pinned jsmolka Thumb entry, branch tests, and memory tests, reviewed for r7 failure IDs, success-marker reset, the Thumb-to-ARM evaluation bridge, and empty-list transfer expectations.
armwrestler-gba-fixed and arm7wrestler, considered as test sources; not integrated.
SingleStepTests ARM7TDMI, considered as an experimental, emulator-generated test source; not integrated.
GBATEK ARM single data transfers, for address calculation, indexing, load extension, and nominal timing.
Arm armasm LDR constraints, reviewed to distinguish portable assembly restrictions from the ARM7 alias behavior tested here.
Pinned halfword alias tests, for loaded-value precedence in pre/post-indexed LDRH aliases.
GBATEK memory alignment.
GBATEK multiply instructions.
GBATEK block transfers.
GBATEK swaps.
GBATEK Thumb register operations.
GBATEK Thumb loads/stores.
GBATEK Thumb address calculation.
GBATEK Thumb stack and multiple transfers, for empty-list PC transfers and 64-byte writeback.
mGBA Thumb transfer implementation and shared memory transfers, reviewed for empty STM/PUSH routing and the extra Thumb instruction width on the stored pipeline PC. This supports executing PC+6, rather than an ordinary PC+4 operand read.
GBATEK Thumb jumps and calls.

Use GBATEK and ARM7TDMI documentation for further hardware work. Only use game ROMs that you may lawfully use. Do not commit game ROMs, BIOS files, or game assets. The ignore file excludes roms/, common game ROM extensions, and save files.

12 KiB Raw Blame History

References

12 KiB

Raw Blame History