mirror of
https://github.com/0xrsydn/idx-cli.git
synced 2026-11-07 01:35:36 +00:00
When Cloudflare answers idx.co.id with a challenge, curl fails with only `curl: (22)`, which exits 4 like any other HTTP failure, and every profile is tried twice. A challenge needs a browser, so no profile can solve it. The source is monthly, so the publisher only needs one run per month to get through: treat a challenge as "retry tomorrow" and alert on stale data. - Add IdxError::CloudflareChallenge (CLOUDFLARECHALLENGE, exit 6), detected from the cf-mitigated header. curl reports it on stderr through --write-out, because --fail drops the response. - A URL with a challenge gets one round of profiles; other failures keep two. This also covers `stocks flow --source idx`, which now exits 6 on a challenge. - -v logs which profile fetched each URL. - Discovery keeps error types, so a challenge survives an announcement miss. A source answering with something unparseable still is not called a challenge. - `ownership discover --require-data-page` fails when the data page cannot be read. Default discover is unchanged: it warns and lists older announcements. - The publisher and builder use that flag, so a failed data page can no longer end in a false "up-to-date". A challenge ends in `RESULT: blocked stage=<stage>`, exit 6; every other failure stays `RESULT: FAILED`. - The systemd example treats exit 6 as success and runs the freshness check, so the unit fails on FAILED or on stale data. - live-smoke reports a challenge as CHALLENGED, a failure and never a pass. Golden change: completions-bash.golden gains `--require-data-page` in the discover options, one word on one line. It is the direct result of the new flag; no other golden file changes. Live check on 2026-11-05 against release/v0.5.0: 19 passed, 2 failed. Both failures are real challenges (flow-idx, discover), each exit 6 with empty stdout. The import, releases and ticker cases did not run, because discover did not pass. Refs #83
129 lines
4.1 KiB
Rust
129 lines
4.1 KiB
Rust
use serde::Serialize;
|
|
use thiserror::Error;
|
|
|
|
#[allow(dead_code)]
|
|
#[derive(Debug, Error, Clone)]
|
|
pub enum IdxError {
|
|
#[error("symbol not found: {0}")]
|
|
SymbolNotFound(String),
|
|
#[error("provider rate limited")]
|
|
RateLimited,
|
|
#[error("provider unavailable")]
|
|
ProviderUnavailable,
|
|
#[error("unsupported: {0}")]
|
|
Unsupported(String),
|
|
#[error("parse error: {0}")]
|
|
ParseError(String),
|
|
#[error("cache miss: {0}")]
|
|
CacheMiss(String),
|
|
#[error("offline: {0}")]
|
|
Offline(String),
|
|
#[error("config error: {0}")]
|
|
ConfigError(String),
|
|
#[error("io error: {0}")]
|
|
Io(String),
|
|
#[error("http error: {0}")]
|
|
Http(String),
|
|
#[error("auth error: {0}")]
|
|
AuthError(String),
|
|
#[error("database error: {0}")]
|
|
DatabaseError(String),
|
|
#[error("PDF parse error: {0}")]
|
|
PdfParseError(String),
|
|
#[error("invalid input: {0}")]
|
|
InvalidInput(String),
|
|
#[error("no market data: {0}")]
|
|
NoMarketData(String),
|
|
/// Cloudflare answered with a challenge only a browser can solve, on every
|
|
/// client tried. Nothing is wrong with the request, so a later run may pass.
|
|
#[error("cloudflare challenge: {0}")]
|
|
CloudflareChallenge(String),
|
|
}
|
|
|
|
#[derive(Debug, Clone, Copy, Serialize, PartialEq, Eq)]
|
|
pub enum ErrorCode {
|
|
SymbolNotFound,
|
|
RateLimited,
|
|
ProviderUnavailable,
|
|
Unsupported,
|
|
ParseError,
|
|
CacheMiss,
|
|
Offline,
|
|
ConfigError,
|
|
Io,
|
|
Http,
|
|
AuthError,
|
|
DatabaseError,
|
|
PdfParseError,
|
|
InvalidInput,
|
|
NoMarketData,
|
|
CloudflareChallenge,
|
|
}
|
|
|
|
/// The stable wire form frontends emit, e.g. `SYMBOLNOTFOUND`.
|
|
impl std::fmt::Display for ErrorCode {
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
f.write_str(&format!("{self:?}").to_uppercase())
|
|
}
|
|
}
|
|
|
|
impl IdxError {
|
|
pub fn code(&self) -> ErrorCode {
|
|
match self {
|
|
Self::SymbolNotFound(_) => ErrorCode::SymbolNotFound,
|
|
Self::RateLimited => ErrorCode::RateLimited,
|
|
Self::ProviderUnavailable => ErrorCode::ProviderUnavailable,
|
|
Self::Unsupported(_) => ErrorCode::Unsupported,
|
|
Self::ParseError(_) => ErrorCode::ParseError,
|
|
Self::CacheMiss(_) => ErrorCode::CacheMiss,
|
|
Self::Offline(_) => ErrorCode::Offline,
|
|
Self::ConfigError(_) => ErrorCode::ConfigError,
|
|
Self::Io(_) => ErrorCode::Io,
|
|
Self::Http(_) => ErrorCode::Http,
|
|
Self::AuthError(_) => ErrorCode::AuthError,
|
|
Self::DatabaseError(_) => ErrorCode::DatabaseError,
|
|
Self::PdfParseError(_) => ErrorCode::PdfParseError,
|
|
Self::InvalidInput(_) => ErrorCode::InvalidInput,
|
|
Self::NoMarketData(_) => ErrorCode::NoMarketData,
|
|
Self::CloudflareChallenge(_) => ErrorCode::CloudflareChallenge,
|
|
}
|
|
}
|
|
|
|
/// Exit status by error class, so scripts can branch without parsing
|
|
/// stderr. Clap usage errors also exit 2. See docs/DESIGN.md.
|
|
pub fn exit_code(&self) -> i32 {
|
|
match self.code() {
|
|
ErrorCode::InvalidInput | ErrorCode::ConfigError => 2,
|
|
ErrorCode::SymbolNotFound | ErrorCode::NoMarketData | ErrorCode::CacheMiss => 3,
|
|
ErrorCode::Http
|
|
| ErrorCode::RateLimited
|
|
| ErrorCode::ProviderUnavailable
|
|
| ErrorCode::Offline
|
|
| ErrorCode::AuthError => 4,
|
|
ErrorCode::Unsupported => 5,
|
|
ErrorCode::CloudflareChallenge => 6,
|
|
ErrorCode::Io
|
|
| ErrorCode::ParseError
|
|
| ErrorCode::DatabaseError
|
|
| ErrorCode::PdfParseError => 1,
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::{ErrorCode, IdxError};
|
|
|
|
#[test]
|
|
fn display_and_code_work() {
|
|
let err = IdxError::SymbolNotFound("BBCA".to_string());
|
|
assert_eq!(err.to_string(), "symbol not found: BBCA");
|
|
assert_eq!(err.code(), ErrorCode::SymbolNotFound);
|
|
|
|
let parse = IdxError::ParseError("bad json".to_string());
|
|
assert_eq!(parse.code(), ErrorCode::ParseError);
|
|
|
|
let unsupported = IdxError::Unsupported("history unavailable".to_string());
|
|
assert_eq!(unsupported.code(), ErrorCode::Unsupported);
|
|
}
|
|
}
|