0xrsydn/idx-cli
1
mirror of https://github.com/0xrsydn/idx-cli.git synced 2026-11-07 09:45:36 +00:00
Code Issues Projects Releases 1 Packages Wiki Activity

fix: expand quoted ~ in install dir and trim trailing slashes on mirror URLs

Browse source 
Addresses Pullfrog review on #24; adds a fixture test for both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017a5Cv5Z1NzdYKgKnTiAF4E
This commit is contained in:
hermes 2026-09-24 19:34:18 +00:00
commit aabb00d3b7
2 changed files with 21 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
scripts/install-sh-test.sh
View file

@ -178,6 +178,18 @@ else
fail "replaces an existing install cleanly"; cat "${work}/out8" >&2
fi
# 9. quoted ~ in --dir expands to HOME; trailing slash on mirror URLs is fine.
# shellcheck disable=SC2088 # the literal ~ is the input under test
if env IDX_GITHUB_URL="http://127.0.0.1:${port}/gh/" \
IDX_GITHUB_API="http://127.0.0.1:${port}/api/" \
HOME="${work}/home" \
"$test_shell" "$installer" --dir "~/tilde-bin" >"${work}/out9" 2>&1 &&
[[ -x "${work}/home/tilde-bin/idx" ]]; then
pass "expands quoted ~ and tolerates trailing slashes"
else
fail "expands quoted ~ and tolerates trailing slashes"; cat "${work}/out9" >&2
fi
if ((failures > 0)); then
echo "install.sh tests: ${failures} failure(s) with ${test_shell}" >&2
exit 1