mirror of
https://github.com/0xrsydn/idx-cli.git
synced 2026-11-07 09:45:36 +00:00
fix(mcp): hand a call's warnings to the agent
idx-core reports what it works around (history falling back to yahoo when Stockbit refuses the session, a stale cache served after a failed fetch, a movements query cut short) as warnings on stderr. An agent never reads idx-mcp's stderr, so it saw `source: "yahoo"` or `stale: true` with no reason. - Each tool call collects its warnings with runtime::on_warning and returns them as `warnings` on the answer or the error, when there are any. - The stale-cache warning names the failure behind it. - The mock's session API 403 is the real session API's block message; the public page's block names IDX_PROVIDER=msn as well as `--provider msn`. Goldens: error-intraday-blocked (json, table) carry the reworded block hint. Claude-Session: https://claude.ai/code/session_01RqPPVeVDrnLoP7NUZmLRxY
This commit is contained in:
parent
e739ee3c20
commit
9b46161566
10 changed files with 145 additions and 18 deletions
|
|
@ -374,6 +374,72 @@ fn stockbit_provider_quotes_carry_market_status_and_blocks_surface_once() {
|
|||
);
|
||||
}
|
||||
|
||||
/// What idx works around reaches the agent as `warnings`, since it never
|
||||
/// sees idx-mcp's stderr: a refused session that made history fall back to
|
||||
/// yahoo, and a movements query cut short. A clean answer has none.
|
||||
#[test]
|
||||
fn workarounds_reach_the_agent_as_warnings() {
|
||||
let mut client = Client::start_with_env(
|
||||
&[],
|
||||
false,
|
||||
&[
|
||||
TEST_SESSION,
|
||||
("IDX_PROVIDER", "stockbit"),
|
||||
("IDX_MOCK_STOCKBIT_STATUS", "401"),
|
||||
],
|
||||
);
|
||||
let history = client.ok(
|
||||
"get_price_history",
|
||||
json!({"symbol": "BBCA", "period": "1mo"}),
|
||||
);
|
||||
assert_eq!(history["source"], "yahoo");
|
||||
let warnings = history["warnings"].as_array().expect("warnings");
|
||||
assert_eq!(warnings.len(), 1, "{warnings:?}");
|
||||
assert!(
|
||||
warnings[0]
|
||||
.as_str()
|
||||
.unwrap()
|
||||
.contains("Stockbit rejected the session")
|
||||
&& warnings[0]
|
||||
.as_str()
|
||||
.unwrap()
|
||||
.contains("falls back to yahoo"),
|
||||
"{warnings:?}"
|
||||
);
|
||||
let analysis = client.ok("analyze_stock", json!({"symbol": "BBCA"}));
|
||||
assert!(
|
||||
analysis["warnings"][0]
|
||||
.as_str()
|
||||
.unwrap()
|
||||
.contains("falls back to yahoo")
|
||||
);
|
||||
// The next call starts with none of the last one's warnings.
|
||||
let (is_error, body) = client.call("get_orderbook", json!({"symbol": "BBCA"}));
|
||||
assert!(is_error && body["code"] == "AUTHERROR", "{body}");
|
||||
assert!(body.get("warnings").is_none(), "{body}");
|
||||
|
||||
let mut client = Client::start_with_env(
|
||||
&[],
|
||||
false,
|
||||
&[TEST_SESSION, ("IDX_MOCK_MOVEMENTS_FAIL_PAGE", "2")],
|
||||
);
|
||||
let partial = client.ok(
|
||||
"get_shareholder_movements",
|
||||
json!({"symbol": "BBCA", "pages": 3}),
|
||||
);
|
||||
assert_eq!(partial["data"]["incomplete"], "provider rate limited");
|
||||
assert!(
|
||||
partial["warnings"][0]
|
||||
.as_str()
|
||||
.unwrap()
|
||||
.contains("showing the 8 rows read before it")
|
||||
);
|
||||
|
||||
let mut client = Client::start_with_env(&[], false, &[TEST_SESSION]);
|
||||
let clean = client.ok("get_shareholder_movements", json!({"symbol": "BBCA"}));
|
||||
assert!(clean.get("warnings").is_none(), "{clean}");
|
||||
}
|
||||
|
||||
/// The sign-in tool answers at once. With no browser to open (the mock
|
||||
/// provider never starts one), auto falls back to the page and says why; the
|
||||
/// page takes the cookie the way the browser would, and stockbit_status
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue