fix(npm): absolute cache root, per-arch cache dir, SIGINT during install

From a second Codex review (gpt-6.1-sol, xhigh):
- A relative XDG_CACHE_HOME (invalid per the XDG spec) made the launcher
  look for, and run, a binary under the current directory, which an
  untrusted checkout could supply. Use it only when absolute.
- The cache dir now includes <platform>-<arch>, so a home directory shared
  across machines cannot hand an arm64 host an x64 binary.
- SIGINT sent to the launcher's PID alone during the first-run install is
  forwarded to the installer (it was ignored); the launcher exits 130.
- npm smoke runs the first-run install with an empty user cache and checks
  the package binary was created, so a cached binary cannot pass for it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V3syn2fN2LNo5pvTSqc6eh
This commit is contained in:
hermes 2026-10-16 08:29:58 +00:00
commit 3041606916
4 changed files with 30 additions and 10 deletions

View file

@ -20,6 +20,7 @@ let child = null;
// A termination signal received while installing; the installer cleans up
// and exits, and the launcher then stops the same way.
let stopping = null;
let installing = false;
// Pass termination signals from a supervisor (kill, docker stop) to the child.
for (const signal of ["SIGTERM", "SIGHUP"]) {
@ -32,8 +33,15 @@ for (const signal of ["SIGTERM", "SIGHUP"]) {
}
});
}
// Ctrl+C already reaches the child through the terminal's process group.
process.on("SIGINT", () => {});
// Ctrl+C already reaches the binary through the terminal's process group, so
// the launcher ignores SIGINT then. During the first-run install, forward it
// too: a supervisor may signal only the launcher's PID.
process.on("SIGINT", () => {
if (installing) {
stopping = "SIGINT";
child.kill("SIGINT");
}
});
function exitLike(code, signal) {
if (signal) {
@ -61,6 +69,7 @@ if (installed) {
// or its download failed: install now. Its log goes to stderr, since stdout
// is the MCP channel for idx-mcp.
console.error(`${packageName}: binary not installed; running the installer`);
installing = true;
child = spawn(process.execPath, [installer], { stdio: ["ignore", 2, 2] });
child.once("error", (error) => {
console.error(`${packageName}: failed to run the installer: ${error.message}`);
@ -68,6 +77,7 @@ if (installed) {
});
child.once("exit", (code, signal) => {
child = null;
installing = false;
if (signal || stopping) {
exitLike(code, signal || stopping);
return;