mirror of
https://github.com/0xrsydn/idx-cli.git
synced 2026-11-07 09:45:36 +00:00
refactor: split into idx-core library and idx-cli binary workspace
Phase 2 of docs/DESIGN.md, no behavior change: - crates/idx-core (library): api, analysis, cache, config file handling and provider selection, curl_impersonate, error, ownership, runtime, plus the shared test fixtures. clap derives are behind an optional `clap` feature so the library does not require clap. - crates/idx-cli (binary `idx`): cli/, output/, and IdxConfig (output format and color resolution). Package and binary names are unchanged. - config.rs is split: file read/write and validation move to core; a CLI test keeps core's OUTPUT_VALUES in sync with OutputSetting. - ownership::db::open_db/db_path drop their unused IdxConfig argument. - One workspace version; shared dependency versions; no third-party version changes in Cargo.lock. LICENSE is symlinked into each crate. - flake: workspace version, new source paths, and a per-crate package check (idx-cli is built from its tarball against packaged idx-core, since idx-core is not on crates.io yet). CI cache key, release path filter, and the golden whitespace-hook exclusion follow the new layout. Parity: all 143 golden outputs match byte for byte without regeneration; 157 core + 17 CLI unit tests (173 before plus the new OUTPUT_VALUES sync test), 62 CLI tests pass. Live A/B against main: 16/16 stocks cases identical; ownership discover got IDX 403 on both (exit 4 vs 1 is the phase 1 exit-code change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
22b6dabaeb
commit
15947de51a
238 changed files with 544 additions and 375 deletions
115
src/error.rs
115
src/error.rs
|
|
@ -1,115 +0,0 @@
|
|||
use serde::Serialize;
|
||||
use thiserror::Error;
|
||||
|
||||
#[allow(dead_code)]
|
||||
#[derive(Debug, Error, Clone)]
|
||||
pub enum IdxError {
|
||||
#[error("symbol not found: {0}")]
|
||||
SymbolNotFound(String),
|
||||
#[error("provider rate limited")]
|
||||
RateLimited,
|
||||
#[error("provider unavailable")]
|
||||
ProviderUnavailable,
|
||||
#[error("unsupported: {0}")]
|
||||
Unsupported(String),
|
||||
#[error("parse error: {0}")]
|
||||
ParseError(String),
|
||||
#[error("cache miss: {0}")]
|
||||
CacheMiss(String),
|
||||
#[error("offline: {0}")]
|
||||
Offline(String),
|
||||
#[error("config error: {0}")]
|
||||
ConfigError(String),
|
||||
#[error("io error: {0}")]
|
||||
Io(String),
|
||||
#[error("http error: {0}")]
|
||||
Http(String),
|
||||
#[error("auth error: {0}")]
|
||||
AuthError(String),
|
||||
#[error("database error: {0}")]
|
||||
DatabaseError(String),
|
||||
#[error("PDF parse error: {0}")]
|
||||
PdfParseError(String),
|
||||
#[error("invalid input: {0}")]
|
||||
InvalidInput(String),
|
||||
#[error("no market data: {0}")]
|
||||
NoMarketData(String),
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Copy, Serialize, PartialEq, Eq)]
|
||||
pub enum ErrorCode {
|
||||
SymbolNotFound,
|
||||
RateLimited,
|
||||
ProviderUnavailable,
|
||||
Unsupported,
|
||||
ParseError,
|
||||
CacheMiss,
|
||||
Offline,
|
||||
ConfigError,
|
||||
Io,
|
||||
Http,
|
||||
AuthError,
|
||||
DatabaseError,
|
||||
PdfParseError,
|
||||
InvalidInput,
|
||||
NoMarketData,
|
||||
}
|
||||
|
||||
impl IdxError {
|
||||
pub fn code(&self) -> ErrorCode {
|
||||
match self {
|
||||
Self::SymbolNotFound(_) => ErrorCode::SymbolNotFound,
|
||||
Self::RateLimited => ErrorCode::RateLimited,
|
||||
Self::ProviderUnavailable => ErrorCode::ProviderUnavailable,
|
||||
Self::Unsupported(_) => ErrorCode::Unsupported,
|
||||
Self::ParseError(_) => ErrorCode::ParseError,
|
||||
Self::CacheMiss(_) => ErrorCode::CacheMiss,
|
||||
Self::Offline(_) => ErrorCode::Offline,
|
||||
Self::ConfigError(_) => ErrorCode::ConfigError,
|
||||
Self::Io(_) => ErrorCode::Io,
|
||||
Self::Http(_) => ErrorCode::Http,
|
||||
Self::AuthError(_) => ErrorCode::AuthError,
|
||||
Self::DatabaseError(_) => ErrorCode::DatabaseError,
|
||||
Self::PdfParseError(_) => ErrorCode::PdfParseError,
|
||||
Self::InvalidInput(_) => ErrorCode::InvalidInput,
|
||||
Self::NoMarketData(_) => ErrorCode::NoMarketData,
|
||||
}
|
||||
}
|
||||
|
||||
/// Exit status by error class, so scripts can branch without parsing
|
||||
/// stderr. Clap usage errors also exit 2. See docs/DESIGN.md.
|
||||
pub fn exit_code(&self) -> i32 {
|
||||
match self.code() {
|
||||
ErrorCode::InvalidInput | ErrorCode::ConfigError => 2,
|
||||
ErrorCode::SymbolNotFound | ErrorCode::NoMarketData | ErrorCode::CacheMiss => 3,
|
||||
ErrorCode::Http
|
||||
| ErrorCode::RateLimited
|
||||
| ErrorCode::ProviderUnavailable
|
||||
| ErrorCode::Offline
|
||||
| ErrorCode::AuthError => 4,
|
||||
ErrorCode::Unsupported => 5,
|
||||
ErrorCode::Io
|
||||
| ErrorCode::ParseError
|
||||
| ErrorCode::DatabaseError
|
||||
| ErrorCode::PdfParseError => 1,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::{ErrorCode, IdxError};
|
||||
|
||||
#[test]
|
||||
fn display_and_code_work() {
|
||||
let err = IdxError::SymbolNotFound("BBCA".to_string());
|
||||
assert_eq!(err.to_string(), "symbol not found: BBCA");
|
||||
assert_eq!(err.code(), ErrorCode::SymbolNotFound);
|
||||
|
||||
let parse = IdxError::ParseError("bad json".to_string());
|
||||
assert_eq!(parse.code(), ErrorCode::ParseError);
|
||||
|
||||
let unsupported = IdxError::Unsupported("history unavailable".to_string());
|
||||
assert_eq!(unsupported.code(), ErrorCode::Unsupported);
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue